Summary

Fixed GitDiffParser mis-parsing git patch files

Review Request #745 — Created Feb. 12, 2009 and submitted

Information

Owner

andreyf

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When a new file is added into git, the path in the patch file doesn't have a "a/" or "b/" prepended to it. Replacing the foo[2:] with re.sub("^[a|b]/", "", foo) fixes the issue.

A couple more details here: http://code.google.com/p/reviewboard/issues/detail?id=883

Testing Done

Expand All
Collapse All

Description:: When a new file is added into git, the path in the patch file doesn't have a "a/" or "b/" prepended to it. Replacing the foo[2:] with re.sub("^[a|b]/", "", foo) fixes the issue.
+
+
A couple more details here: http://code.google.com/p/reviewboard/issues/detail?id=883

Ship it!

```
????????
????
```
1. PE
  
  pechnik Feb. 18, 2009, 1:09 a.m.
  tre

Ship it!

```
Looks great. Committed as r1814.
```

		When a new file is added into git, the path in the patch file doesn't have a "a/" or "b/" prepended to it. Replacing the foo[2:] with re.sub("^[a\|b]/", "", foo) fixes the issue.
	+
	+	A couple more details here: http://code.google.com/p/reviewboard/issues/detail?id=883