Add a comment-type categorization extension.

Review Request #7444 — Created June 22, 2015 and submitted

david
rb-extension-pack
master
d578e57...
rb-extension-pack

This new extension allows people to configure a set of available "types" for
comments, and either allow or require users to set the type of each comment.
Once set, the comment type is visible next to each comment in the review, and
can be retrieved via the extra_data field in the API.

  • Added, removed, and edited comment types in the extension's configuration
    interface. Verified that the list was always saved correctly.
  • Tested that the configured types showed up properly in the comment dialog and
    review dialog. Checked that when 'require ...' was unchecked there was an
    empty option listed first, and that the visibility flag was handled
    correctly.
  • Tested opening the comment dialog and review dialog for existing comments
    that didn't have a type set, and that there was an empty option preselected.
  • Tested saving the type from the comment dialog and review dialog. Checked
    that it was always persisted correctly. Tested that the initial selection was
    correct when opening comments with a saved type.
  • Tested the display of the type in the reviews page.
Loading file attachments...

Description From Last Updated

Alphabetize.

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbcommenttype/rbcommenttype/forms.py
        rbcommenttype/rbcommenttype/admin_urls.py
        rbcommenttype/setup.py
        rbcommenttype/rbcommenttype/extension.py
    
    Ignored Files:
        rbcommenttype/rbcommenttype/templates/rbcommenttype-types.html
        rbcommenttype/rbcommenttype/static/js/configure.js
        rbcommenttype/rbcommenttype/static/css/configure.less
        rbcommenttype/rbcommenttype/__init__.py
        rbcommenttype/rbcommenttype/static/js/commentType.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbcommenttype/rbcommenttype/forms.py
        rbcommenttype/rbcommenttype/admin_urls.py
        rbcommenttype/setup.py
        rbcommenttype/rbcommenttype/extension.py
    
    Ignored Files:
        rbcommenttype/rbcommenttype/templates/rbcommenttype-types.html
        rbcommenttype/rbcommenttype/static/js/configure.js
        rbcommenttype/rbcommenttype/static/css/configure.less
        rbcommenttype/rbcommenttype/__init__.py
        rbcommenttype/rbcommenttype/static/js/commentType.js
    
    
  2. 
      
brennie
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbcommenttype/rbcommenttype/forms.py
        rbcommenttype/rbcommenttype/admin_urls.py
        rbcommenttype/setup.py
        rbcommenttype/rbcommenttype/extension.py
    
    Ignored Files:
        rbcommenttype/rbcommenttype/templates/rbcommenttype-types.html
        rbcommenttype/rbcommenttype/static/js/configure.js
        rbcommenttype/rbcommenttype/static/css/configure.less
        rbcommenttype/rbcommenttype/__init__.py
        rbcommenttype/rbcommenttype/static/js/commentType.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbcommenttype/rbcommenttype/forms.py
        rbcommenttype/rbcommenttype/admin_urls.py
        rbcommenttype/setup.py
        rbcommenttype/rbcommenttype/extension.py
    
    Ignored Files:
        rbcommenttype/rbcommenttype/templates/rbcommenttype-types.html
        rbcommenttype/rbcommenttype/static/js/configure.js
        rbcommenttype/rbcommenttype/static/css/configure.less
        rbcommenttype/rbcommenttype/__init__.py
        rbcommenttype/rbcommenttype/static/js/commentType.js
    
    
  2. 
      
brennie
  1. Ship It!
    1. Though I have enabled 'Require Comment Type' configure.
      It is still allowing comment without 'Comment Type'

      Also I need to know the API or way to see the 'Comment Type' categorization dashboard and data on repository or branch.

    2. Also is there a way to make anyone 'Comment Type' as default?

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (23f26de)
Loading...