Summary

Fix issue 3894, mercurial is not consistent with path separators

Review Request #7443 — Created June 22, 2015 and submitted June 24, 2015, 5:17 p.m.

Information

Owner

kamali.ali

Repository

RBTools

Branch

Bugs

3894

Depends On

Reviewers

Groups

rbtools

People

Description

On Windows hg locate set:size(0) uses backslash as path separator where hg locate uses forward slash. This causes set difference calculations to not match files correctly. This fix replaces backslash with forward slash as a workaround for this mercurial issue.

Testing Done

After this patch rbt no longer includes existing empty files in the diff posted to the reviewboard server. I haven't run the test suite (sorry don't have the time to set everything up).

Issues

Description	From	Last Updated
Col: 41 E261 at least two spaces before inline comment	reviewbot	June 22, 2015, 2:48 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/mercurial.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/mercurial.py

rbtools/clients/mercurial.py (Diff revision 1)
Show all issues
```
Col: 41
 E261 at least two spaces before inline comment
```
1. brennie June 22, 2015, 1:11 p.m.
  Likewise for this issue.

Can you fill in the bug field and add testing done? (did you run the unit tests?)

Testing Done:

After this patch rbt no longer includes existing empty files in the diff posted to the reviewboard server. I haven't run the test suite (sorry don't have the time to set everything up).

Bugs:

+	3894

Diff:

Revision 2 (+1)

Show changes

rbtools/clients/mercurial.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/mercurial.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/mercurial.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (37e81da)