Fix issue 3894, mercurial is not consistent with path separators

Review Request #7443 — Created June 22, 2015 and submitted

Information

RBTools

Reviewers

On Windows hg locate set:size(0) uses backslash as path separator where hg locate uses forward slash. This causes set difference calculations to not match files correctly. This fix replaces backslash with forward slash as a workaround for this mercurial issue.

After this patch rbt no longer includes existing empty files in the diff posted to the reviewboard server. I haven't run the test suite (sorry don't have the time to set everything up).

Description From Last Updated

Col: 41 E261 at least two spaces before inline comment

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/mercurial.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/mercurial.py
    
    
  2. rbtools/clients/mercurial.py (Diff revision 1)
     
     
    Show all issues
    Col: 41
     E261 at least two spaces before inline comment
    
    1. Likewise for this issue.

  3. 
      
brennie
  1. Can you fill in the bug field and add testing done? (did you run the unit tests?)

  2. 
      
KA
KA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/mercurial.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/mercurial.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
KA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (37e81da)