Summary

Fix extensions support on Django 1.7+.

Review Request #7420 — Created June 13, 2015 and submitted June 17, 2015, 3:52 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

12c40d2...

Reviewers

Groups

djblets

People

Description

This fixes the extension cache clearing and other compatibility issues
hit with newer versions of Django. We were using some private APIs in
earlier versions of Django, which have been replaced (largely by proper
APIs) in newer versions of Django.

The old template loader has been marked deprecated, and will be removed
in a future release. The loader will now show a warning when in use.
Documentation has been added to cover this.

Testing Done

Related unit tests pass on Django 1.6 and 1.8.

Issues

Description	From	Last Updated
Needs a docstring.	brennie	June 16, 2015, 4:14 p.m.
This should be a list comprehension.	david	June 16, 2015, 2:02 a.m.
We should probably kill these headers when we see them (unless there's some specific copyright info for other people that …	david	June 17, 2015, 3:52 p.m.

Tool: Pyflakes
Processed Files:
    djblets/extensions/loaders.py
    djblets/extensions/manager.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/loaders.py
    djblets/extensions/manager.py

djblets/extensions/manager.py (Diff revision 1)

The issue has been dropped. Show all issues

This should be a list comprehension.

chipx86 June 16, 2015, 2:02 a.m.

It's concatenating lists, not building a list from items. A list comprehension could be written using itertools, but it'd be more complex than this (and would just do this under the hood anyway).

djblets/extensions/loaders.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a docstring.
```

Change Summary:


Added a compatibility function to unbreak consumers of the old loader, with a deprecation warning.
Added documentation.

Description:

		This fixes the extension cache clearing and other compatibility issues
		hit with newer versions of Django. We were using some private APIs in
		earlier versions of Django, which have been replaced (largely by proper
		APIs) in newer versions of Django.

~		There is one change that introduces a backwards-compatibility issue,
~		which is that the old template loader has been rewritten to be a modern
~		Django template laoder class. The old function-style loaders have been
	~	The old template loader has been marked deprecated, and will be removed
	~	in a future release. The loader will now show a warning when in use.
	~	Documentation has been added to cover this.
-		deprecated for a little while, and we were overdue for fixing this.
-		Applications will need to update accordingly.

Commit:

-	09c4a8832aae0ac09268b42d3662d307a5f89f59
+	16caa8f5b01f19ade984d99bde40eebf54143b54

Diff:

Revision 2 (+85 -21)

Show changes

	djblets/extensions/loaders.py
	djblets/extensions/manager.py

Tool: Pyflakes
Processed Files:
    djblets/extensions/loaders.py
    djblets/extensions/manager.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/loaders.py
    djblets/extensions/manager.py

Change Summary:

Now uses the new base loader for templates, if available. The original one, which is supposed to be backwards-compatible, breaks on 1.8.

Commit:

-	16caa8f5b01f19ade984d99bde40eebf54143b54
+	12c40d2cc87b4682a92712f8012d28060557e07f

Diff:

Revision 3 (+89 -21)

Show changes

	djblets/extensions/loaders.py
	djblets/extensions/manager.py

Tool: Pyflakes
Processed Files:
    djblets/extensions/loaders.py
    djblets/extensions/manager.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/loaders.py
    djblets/extensions/manager.py

Ship it!

djblets/extensions/loaders.py (Diff revision 3)

The issue has been resolved. Show all issues

We should probably kill these headers when we see them (unless there's some specific copyright info for other people that needs to be preserved).

Status: Closed (submitted)

Change Summary:

Pushed to release-0.9.x (bfb55a9)