Fix extensions support on Django 1.7+.

Review Request #7420 — Created June 13, 2015 and submitted

Information

Djblets
release-0.9.x
12c40d2...

Reviewers

This fixes the extension cache clearing and other compatibility issues
hit with newer versions of Django. We were using some private APIs in
earlier versions of Django, which have been replaced (largely by proper
APIs) in newer versions of Django.

The old template loader has been marked deprecated, and will be removed
in a future release. The loader will now show a warning when in use.
Documentation has been added to cover this.

Related unit tests pass on Django 1.6 and 1.8.

Description From Last Updated

Needs a docstring.

brenniebrennie

This should be a list comprehension.

daviddavid

We should probably kill these headers when we see them (unless there's some specific copyright info for other people that …

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/extensions/loaders.py
        djblets/extensions/manager.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/extensions/loaders.py
        djblets/extensions/manager.py
    
    
  2. 
      
david
  1. 
      
  2. djblets/extensions/manager.py (Diff revision 1)
     
     
     
     
     
    Show all issues

    This should be a list comprehension.

    1. It's concatenating lists, not building a list from items. A list comprehension could be written using itertools, but it'd be more complex than this (and would just do this under the hood anyway).

  3. 
      
brennie
  1. 
      
  2. djblets/extensions/loaders.py (Diff revision 1)
     
     
    Show all issues

    Needs a docstring.

  3. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/extensions/loaders.py
        djblets/extensions/manager.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/extensions/loaders.py
        djblets/extensions/manager.py
    
    
  2. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/extensions/loaders.py
        djblets/extensions/manager.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/extensions/loaders.py
        djblets/extensions/manager.py
    
    
  2. 
      
david
  1. 
      
  2. djblets/extensions/loaders.py (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    We should probably kill these headers when we see them (unless there's some specific copyright info for other people that needs to be preserved).

  3. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.9.x (bfb55a9)