Register some apps on Djblets for Django 1.7+.

Review Request #7419 — Created June 13, 2015 and submitted

Information

Djblets
release-0.9.x
9192972...

Reviewers

We have a few apps on Djblets that could conflict with app labels from
the consumer. Django didn't used to care about this, but starting in
Django 1.7, there's an app registry that ensures uniqueness.

To fix these conflicts, AppConfigs are now registered for each app,
with only a couple exceptions. Not all of our apps need to be added to
INSTALLED_APPS, but since they may be, we're covering nearly all of
them. The table names have also been updated to use the original names,
for backwards-compatibility.

This will only affect Django 1.7+, and has no bearing on Django 1.6
(which doesn't let you specify app labels anyway).

No longer saw problems with Django complaining about duplicate apps.

Unit tests pass (along with all other upcoming changes).

Description From Last Updated

Where did all the stuff in this file go?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/forms/apps.py
        djblets/db/apps.py
        djblets/log/apps.py
        djblets/util/apps.py
        djblets/template/apps.py
        djblets/webapi/__init__.py
        djblets/cache/__init__.py
        djblets/datagrid/apps.py
        djblets/feedview/__init__.py
        djblets/extensions/apps.py
        djblets/auth/apps.py
        djblets/configforms/apps.py
        djblets/gravatars/apps.py
        djblets/webapi/apps.py
        djblets/markdown/__init__.py
        djblets/siteconfig/models.py
        djblets/cache/apps.py
        djblets/template/__init__.py
        djblets/siteconfig/__init__.py
        djblets/util/__init__.py
        djblets/log/__init__.py
        djblets/extensions/models.py
        djblets/feedview/apps.py
        djblets/pipeline/__init__.py
        djblets/extensions/__init__.py
        djblets/pipeline/apps.py
        djblets/auth/__init__.py
        djblets/db/__init__.py
        djblets/markdown/apps.py
        djblets/datagrid/__init__.py
        djblets/siteconfig/apps.py
        djblets/forms/__init__.py
        djblets/gravatars/__init__.py
        djblets/configforms/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/forms/apps.py
        djblets/db/apps.py
        djblets/log/apps.py
        djblets/util/apps.py
        djblets/template/apps.py
        djblets/webapi/__init__.py
        djblets/cache/__init__.py
        djblets/datagrid/apps.py
        djblets/feedview/__init__.py
        djblets/extensions/apps.py
        djblets/auth/apps.py
        djblets/configforms/apps.py
        djblets/gravatars/apps.py
        djblets/webapi/apps.py
        djblets/markdown/__init__.py
        djblets/siteconfig/models.py
        djblets/cache/apps.py
        djblets/template/__init__.py
        djblets/siteconfig/__init__.py
        djblets/util/__init__.py
        djblets/log/__init__.py
        djblets/extensions/models.py
        djblets/feedview/apps.py
        djblets/pipeline/__init__.py
        djblets/extensions/__init__.py
        djblets/pipeline/apps.py
        djblets/auth/__init__.py
        djblets/db/__init__.py
        djblets/markdown/apps.py
        djblets/datagrid/__init__.py
        djblets/siteconfig/apps.py
        djblets/forms/__init__.py
        djblets/gravatars/__init__.py
        djblets/configforms/__init__.py
    
    
  2. 
      
david
  1. 
      
  2. djblets/markdown/__init__.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Where did all the stuff in this file go?

    1. Oops. Overwrote the file.. Fixing.

  3. 
      
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/forms/apps.py
        djblets/db/apps.py
        djblets/log/apps.py
        djblets/util/apps.py
        djblets/template/apps.py
        djblets/webapi/__init__.py
        djblets/cache/__init__.py
        djblets/datagrid/apps.py
        djblets/feedview/__init__.py
        djblets/extensions/apps.py
        djblets/auth/apps.py
        djblets/configforms/apps.py
        djblets/gravatars/apps.py
        djblets/webapi/apps.py
        djblets/markdown/__init__.py
        djblets/siteconfig/models.py
        djblets/cache/apps.py
        djblets/template/__init__.py
        djblets/siteconfig/__init__.py
        djblets/util/__init__.py
        djblets/log/__init__.py
        djblets/extensions/models.py
        djblets/feedview/apps.py
        djblets/pipeline/__init__.py
        djblets/extensions/__init__.py
        djblets/pipeline/apps.py
        djblets/auth/__init__.py
        djblets/db/__init__.py
        djblets/markdown/apps.py
        djblets/datagrid/__init__.py
        djblets/siteconfig/apps.py
        djblets/forms/__init__.py
        djblets/gravatars/__init__.py
        djblets/configforms/__init__.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/forms/apps.py
        djblets/db/apps.py
        djblets/log/apps.py
        djblets/util/apps.py
        djblets/template/apps.py
        djblets/webapi/__init__.py
        djblets/cache/__init__.py
        djblets/datagrid/apps.py
        djblets/feedview/__init__.py
        djblets/extensions/apps.py
        djblets/auth/apps.py
        djblets/configforms/apps.py
        djblets/gravatars/apps.py
        djblets/webapi/apps.py
        djblets/markdown/__init__.py
        djblets/siteconfig/models.py
        djblets/cache/apps.py
        djblets/template/__init__.py
        djblets/siteconfig/__init__.py
        djblets/util/__init__.py
        djblets/log/__init__.py
        djblets/extensions/models.py
        djblets/feedview/apps.py
        djblets/pipeline/__init__.py
        djblets/extensions/__init__.py
        djblets/pipeline/apps.py
        djblets/auth/__init__.py
        djblets/db/__init__.py
        djblets/markdown/apps.py
        djblets/datagrid/__init__.py
        djblets/siteconfig/apps.py
        djblets/forms/__init__.py
        djblets/gravatars/__init__.py
        djblets/configforms/__init__.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.9.x (0c82d59)
Loading...