Fix display of filediffs which are copied with no modifications.

Review Request #7416 — Created June 12, 2015 and submitted

smacleod
Review Board
release-2.0.x
049db57...
reviewboard
brennie, chipx86
In the case where a file had no modifications and was moved we wouldn't
bother trying to generate chunks. We now exhibit the same behaviour for
copied files.

In particular this fixes a bug with hg repositories where unmodified
copies would fail to display with an error about diff application.
This error does not seem to happen in the git case because of a
difference in how UNKNOWN revisions and diff application are handled.

As a follow up it might be worthwhile to investigate why unknown
revisions are represented and handled differently, but this fix is
still valid as we shouldn't be generating chunks in this case.

Observed that the unmodified copy case is now fixed for hg, and remains the same for git.

Unit tests all pass.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
SM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (8376074)
Loading...