Fix WebAPI errors returning empty messages
Review Request #7415 — Created June 12, 2015 and submitted
Previously, the WebAPI would sometimes return a empty error. This was
because we were referring to themsgattribute of the underlying
exception, instead of casting it to a text type.Also fix some typos that were introduced in the errors module.
Unit tests have been introduced to test the behaviour of raising a
ReopenError,CloseError, andPublishingErrorduring a review
request reopen, close, and publish, respectively.
Ran unit tests.
Description: |
|
|||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||
Commit: |
|
|||||||||||||||
Diff: |
Revision 2 (+10 -9) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/review_reply.py reviewboard/reviews/errors.py reviewboard/webapi/resources/review_request.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/review_reply.py reviewboard/reviews/errors.py reviewboard/webapi/resources/review_request.py
-
Guess we don't have unit tests around this. Can you add some? I want to be sure this can never happen again.
Change Summary:
Unit tests
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 3 (+107 -10) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/tests/test_review_request.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/base_review.py reviewboard/reviews/errors.py reviewboard/webapi/resources/review_reply.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/tests/test_review_request.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/base_review.py reviewboard/reviews/errors.py reviewboard/webapi/resources/review_reply.py -
reviewboard/webapi/tests/test_review_request.py (Diff revision 3) Col: 54 E241 multiple spaces after ','
-
reviewboard/webapi/tests/test_review_request.py (Diff revision 3) Col: 45 E127 continuation line over-indented for visual indent
-
reviewboard/webapi/tests/test_review_request.py (Diff revision 3) Col: 1 E302 expected 2 blank lines, found 1
-
reviewboard/webapi/tests/test_review_request.py (Diff revision 3) local variable 'draft' is assigned to but never used
Change Summary:
PEP8
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+108 -10) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/tests/test_review_request.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/base_review.py reviewboard/reviews/errors.py reviewboard/webapi/resources/review_reply.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/tests/test_review_request.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/base_review.py reviewboard/reviews/errors.py reviewboard/webapi/resources/review_reply.py
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/review_reply.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/review_reply.py