Summary

Fix WebAPI errors returning empty messages

Review Request #7415 — Created June 12, 2015 and submitted June 12, 2015, 6:06 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

d2948c9...

Reviewers

Groups

reviewboard

People

Description

Previously, the WebAPI would sometimes return a empty error. This was

because we were referring to the msg attribute of the underlying

exception, instead of casting it to a text type.
Also fix some typos that were introduced in the errors module.
Unit tests have been introduced to test the behaviour of raising a

ReopenError, CloseError, and PublishingError during a review 

request reopen, close, and publish, respectively.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 54 E241 multiple spaces after ','	reviewbot	June 12, 2015, 3:24 p.m.
Col: 45 E127 continuation line over-indented for visual indent	reviewbot	June 12, 2015, 3:24 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	June 12, 2015, 3:24 p.m.
local variable 'draft' is assigned to but never used	reviewbot	June 12, 2015, 3:24 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/review_reply.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/review_reply.py

Ship it!

```
Ship It!
```

Description:

		Previously, the WebAPI would sometimes return a empty error. This was
		because we were referring to the `msg` attribute of the underlying
		exception, instead of casting it to a text type.
	+
	+	Also fix some typos that were introduced in the errors module.

Testing Done:

	+	Created an extension that raised `PublishError` and `ReopenError`.
	+	Verified they were caught and returned the appropriate API errors.

Commit:

3dd552df7c7e461a51ef88446fbea5286f730976

79d58297e05d54ccb265096c3bd20aae5485244d

Diff:

Revision 2 (+10 -9)

Show changes

	reviewboard/reviews/errors.py
	reviewboard/webapi/resources/base_review.py
	reviewboard/webapi/resources/review_reply.py
	reviewboard/webapi/resources/review_request.py
	reviewboard/webapi/resources/review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/reviews/errors.py
    reviewboard/webapi/resources/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/reviews/errors.py
    reviewboard/webapi/resources/review_request.py

Ship it!

```
Ship It!
```

Guess we don't have unit tests around this. Can you add some? I want to be sure this can never happen again.

Change Summary:

Unit tests

Description:

		Previously, the WebAPI would sometimes return a empty error. This was
		because we were referring to the `msg` attribute of the underlying
		exception, instead of casting it to a text type.

		Also fix some typos that were introduced in the errors module.
	+
	+	Unit tests have been introduced to test the behaviour of raising a
	+	`ReopenError`, `CloseError`, and `PublishingError` during a review
	+	request reopen, close, and publish, respectively.

Testing Done:

~		Created an extension that raised `PublishError` and `ReopenError`.
	~	Ran unit tests.
-		Verified they were caught and returned the appropriate API errors.

Commit:

79d58297e05d54ccb265096c3bd20aae5485244d

f12dd01123fc825b32ecfd0d45a65944230a3260

Diff:

Revision 3 (+107 -10)

Show changes

	reviewboard/reviews/errors.py
	reviewboard/webapi/resources/base_review.py
	reviewboard/webapi/resources/review_reply.py
	reviewboard/webapi/resources/review_request.py
	reviewboard/webapi/resources/review_request_draft.py
	reviewboard/webapi/tests/test_review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/reviews/errors.py
    reviewboard/webapi/resources/review_reply.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/reviews/errors.py
    reviewboard/webapi/resources/review_reply.py

reviewboard/webapi/tests/test_review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 54
 E241 multiple spaces after ','
```
reviewboard/webapi/tests/test_review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 45
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/webapi/tests/test_review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 local variable 'draft' is assigned to but never used
```

Change Summary:

PEP8

Commit:

f12dd01123fc825b32ecfd0d45a65944230a3260

d2948c9b6dbc5eb68c20832b586491d0ad4d90d7

Diff:

Revision 4 (+108 -10)

Show changes

	reviewboard/reviews/errors.py
	reviewboard/webapi/resources/base_review.py
	reviewboard/webapi/resources/review_reply.py
	reviewboard/webapi/resources/review_request.py
	reviewboard/webapi/resources/review_request_draft.py
	reviewboard/webapi/tests/test_review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/reviews/errors.py
    reviewboard/webapi/resources/review_reply.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/tests/test_review_request.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/reviews/errors.py
    reviewboard/webapi/resources/review_reply.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (cb5346f)