Summary

Update diffviewer JS to set condensed diff properties

Review Request #7402 — Created June 10, 2015 and submitted June 11, 2015, 5:01 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

~~7403~~, ~~7398~~

Reviewers

Groups

reviewboard

People

Description

The diffviewer can now set the condensed_diff and base_commit_id on
individual diff comments in the database. These attributes are piped
from the RB.DiffViewerPageView all the way to the RB.DiffComment
model.

Some methods have been added to the RB.DiffCommitIndexView for
determining the currently selected range, if an inter-commit diff is
being displayed, and for determining the "distance" between two commits
(assuming the history is linear).

Testing Done

Made comments on diff commits. Checked the outgoing requests and
incoming responses and verified they were correct.

Issues

Description	From	Last Updated
You don't need this else case (baseCommitID is initialized to null)	david	June 11, 2015, 11:02 a.m.
Indent the .stuff only 4 spaces, not 8.	david	June 11, 2015, 11:02 a.m.
Cumulative should be capitalized.	david	June 11, 2015, 11 a.m.
Cumulative should be capitalized.	david	June 11, 2015, 11 a.m.
"Cumulative" should be capitalized.	david	June 11, 2015, 11 a.m.
Undo this added line.	david	June 11, 2015, 11:01 a.m.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/diffCommentModel.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/diffCommentModel.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Change Summary:

Change condensed to cumulative

Diff:

Revision 2 (+159 -33)

Show changes

	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.js
	reviewboard/static/rb/js/resources/models/diffCommentModel.js
	reviewboard/static/rb/js/resources/models/reviewModel.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/diffCommentModel.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/diffCommentModel.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

reviewboard/static/rb/js/pages/views/diffViewerPageView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
You don't need this else case (baseCommitID is initialized to null)
```
reviewboard/static/rb/js/pages/views/diffViewerPageView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Indent the .stuff only 4 spaces, not 8.
```
reviewboard/static/rb/js/resources/models/diffCommentModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Cumulative should be capitalized.
```
reviewboard/static/rb/js/resources/models/diffCommentModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Cumulative should be capitalized.
```
reviewboard/static/rb/js/resources/models/reviewModel.js (Diff revision 2)
The issue has been resolved. Show all issues
```
"Cumulative" should be capitalized.
```
reviewboard/static/rb/js/views/textCommentRowSelector.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Undo this added line.
```

Change Summary:

Address David's issues.

Diff:

Revision 3 (+156 -33)

Show changes

	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.js
	reviewboard/static/rb/js/resources/models/diffCommentModel.js
	reviewboard/static/rb/js/resources/models/reviewModel.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/diffCommentModel.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/diffCommentModel.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/resources/models/reviewModel.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (43c7313)