Summary

Fix issues with file encoding, newlines in rbtools/TFS.

Review Request #7401 — Created June 9, 2015 and submitted June 9, 2015, 5:37 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

e715721...

Reviewers

Groups

rbtools

People

Description

This change fixes up our diff processing to always work in bytes, rather than
trying to deal with unicode. It also fixes the diffing to work properly when
files don't end in a newline.

Testing Done

Posted a few changes that involved previously problematic files.

Issues

Description	From	Last Updated
Any issue with unicode vs. bytestring here?	chipx86	June 9, 2015, 4:59 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/tfs.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tfs.py

rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Any issue with unicode vs. bytestring here?
```

Commit:

-	ee799c6fe3ab1009ee5440803c2c0ca7d2e67100
+	e715721e56cd7a402b65efb51d0252b069374dd2

Diff:

Revision 2 (+34 -23)

Show changes

rbtools/clients/tfs.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tfs.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/tfs.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (e777703)

rbtools/clients/tfs.py (Diff revision 1)