Summary

Fix Git diffs containing tabs after the filename.

Review Request #7397 — Created June 9, 2015 and submitted June 9, 2015, 4:04 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

58533e3...

Reviewers

Groups

reviewboard

People

Description

We found a case where a user had a generated Git diff that contained
tabs after the filename, as if more data would follow. Our parser wasn't
expecting this, and ended up including the tab along with the filename.

Now, any extra whitespace around the filename is stripped away, allowing
the files to be properly matched against the repository.

Testing Done

The new unit test failed without the fix, and passed with it.

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py

Hm. It's probably less likely, but what happens if the filenames actually end in a tab character or space?

chipx86 June 9, 2015, 3:05 p.m.

There's nothing we can really do about that, I don't think... Diffs are stupid.
The broken diff from that one user who hit this looks like:

--- <filename>\t
+++ <filename>\t


for each diff.

david June 9, 2015, 3:06 p.m.
```
OK. Ship it, I guess.
```

chipx86 June 9, 2015, 3:06 p.m.

I could alter this to only strip away the last \t, and ignore spaces?

david June 9, 2015, 3:17 p.m.
```
That sounds safer.
```

Change Summary:

Changed this to strip only a single trailing tab.

Commit:

-	cb565c7ac30fdcc961f71987b8f34675c07bb50a
+	58533e3fe4c4ed52a4c381149c2ca45c4c6e16c7

Diff:

Revision 2 (+38)

Show changes

	reviewboard/scmtools/git.py
	reviewboard/scmtools/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (f7ac17f)