Summary

Add a missing anchor for "new" copied files in the diff viewer.

Review Request #7384 — Created June 5, 2015 and submitted June 5, 2015, 5:08 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

86d11db...

Reviewers

Groups

reviewboard

People

Description

Files that were marked both as "new" and also copied from another file
were missing an anchor, causing the file index to fail. This is pretty
rare, so it wasn't reported before, but we had a case where it happened
just recently.

We should now have an anchor in all cases.

Testing Done

Tested with a file in this state. Saw the anchor. Clicking the file index
took me there.

Tool: Pyflakes
Ignored Files:
    reviewboard/templates/diffviewer/diff_file_fragment.html



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/diffviewer/diff_file_fragment.html

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (bf7d9de)

Ship it!

Just wanted to note that I'm pretty sure this is #3654 (https://code.google.com/p/reviewboard/issues/detail?id=3654), that I reported a while back. As far as I can tell, I can no longer produce the issue with this patch applied. Thanks!

chipx86 June 5, 2015, 5:45 p.m.

You're right, it is. Thanks! I'll make sure we note that in the release notes.