Add a missing anchor for "new" copied files in the diff viewer.

Review Request #7384 — Created June 5, 2015 and submitted

chipx86
Review Board
release-2.0.x
86d11db...
reviewboard
Files that were marked both as "new" and also copied from another file
were missing an anchor, causing the file index to fail. This is pretty
rare, so it wasn't reported before, but we had a case where it happened
just recently.

We should now have an anchor in all cases.

Tested with a file in this state. Saw the anchor. Clicking the file index
took me there.

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/diffviewer/diff_file_fragment.html
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/diffviewer/diff_file_fragment.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (bf7d9de)
gmyers
  1. Just wanted to note that I'm pretty sure this is #3654 (https://code.google.com/p/reviewboard/issues/detail?id=3654), that I reported a while back. As far as I can tell, I can no longer produce the issue with this patch applied. Thanks!

    1. You're right, it is. Thanks! I'll make sure we note that in the release notes.

  2. 
      
Loading...