JS resources now use functions for defaults
Review Request #7381 — Created June 4, 2015 and submitted
Previously, the
RB.BaseResourcemodel was using an object literal for
its defaults, but its default value for extra data was an empty object.
This could possibly result in shared state if a resource did not return
anextra_dataJSON field, so thedefaultsproperty has been changed
into a function to avoid this.All child resources of
RB.BaseResourcehave been modified to use a
function instead of an attribute fordefaultsand to correctly invoke
the parent class's definition ofdefaults.
Ran JS tests.
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 2 (+309 -273) |
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js
-
-
reviewboard/static/rb/js/resources/models/baseCommentModel.js (Diff revision 2) The line is now too long.
I suspect there are others, but I can't easily check here (we really need that feature).
-
-
reviewboard/static/rb/js/resources/models/baseCommentModel.js (Diff revision 2) Not sure we need to bother with the
.call(this), since the context doesn't actually matter in any of these (nor should they, as the defaults functions shouldn't assume any information on the instance). (Doesn't hurt, though, and I can be convinced otherwise, but worth bringing up.) -
reviewboard/static/rb/js/resources/models/defaultReviewerModel.js (Diff revision 2) This is over-indented.
Change Summary:
Addressed issues.
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js
Change Summary:
Fix some typos
Commit: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+311 -273)
|
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js
Change Summary:
Fix typo
Commit: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+311 -273)
|
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/resources/models/reviewGroupModel.js reviewboard/static/rb/js/resources/models/fileAttachmentModel.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/resources/models/diffCommentModel.js reviewboard/static/rb/js/resources/models/diffModel.js reviewboard/static/rb/js/resources/models/fileDiffModel.js reviewboard/static/rb/js/resources/models/reviewReplyModel.js reviewboard/static/rb/js/resources/models/screenshotCommentModel.js reviewboard/static/rb/js/resources/models/baseResourceModel.js reviewboard/static/rb/js/resources/models/baseCommentModel.js reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/resources/models/screenshotModel.js reviewboard/static/rb/js/resources/models/fileAttachmentCommentModel.js reviewboard/static/rb/js/resources/models/defaultReviewerModel.js reviewboard/static/rb/js/resources/models/baseCommentReplyModel.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js reviewboard/static/rb/js/resources/models/reviewModel.js
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/resources/models/baseResourceModel.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/resources/models/baseResourceModel.js