Summary

fix syntax highlighting for cvs diff and multibyte language diff

Review Request #738 — Created Feb. 4, 2009 and discarded

Information

Owner

lepton

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

There are two change:
1. for cvs diff, filename we got from diff file will be something like  "a.python,v", if we don't strip ",v", then syntax hightliging won't work.
2. tell pygments encoding is "utf-8", otherwise chinese (or other multibyte language) character in source code won't display correctly

Testing Done

/trunk/reviewboard/diffviewer/diffutils.py (Diff revision 1)

for readability, you can write this as:

if filenames.endswith(',v):


(should work fine with python2.4 onwards.

sbrown Feb. 5, 2009, 5:47 p.m.

oops, I meant "filename" not "filenames".

This is probably the wrong place to do this.

CVSTool should probably be modifying the stored filenames to not include the ",v". In fact, it looks like this is what it's doing. This would be needed for older files, but newer ones. We should investigate why this isn't working on your install.