Summary

Make the --diff-filename and --update flags mutually exclusive.

Review Request #7358 — Created May 31, 2015 and submitted June 2, 2015, 1:40 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.7.x

Bugs

3755

Depends On

Commit

c95c458...

Reviewers

Groups

rbtools

People

Description

When specifying an external diff file, we can't use --update to automatically
guess which review request to update. This change adds a check for that case.

Testing Done

Tried to run with both arguments and saw the error.

Issues

Description	From	Last Updated
% should be on next line.	brennie	June 2, 2015, 1:36 p.m.
% should be on next line.	brennie	June 2, 2015, 1:36 p.m.
Why trailing newline?	brennie	June 1, 2015, 1:25 p.m.
These parentheses are redundant because of the surrounding parenthesis from CommandError, no?	brennie	June 2, 2015, 1:36 p.m.
Shouldn't this be on the previous line?	brennie	June 2, 2015, 1:36 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py

rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Why trailing newline?
```
1. david June 1, 2015, 1:26 p.m.
  Many of the others had it. I'll fix them all up.

Commit:

-	daf03ee96549e37727941bfce254935588539901
+	c95c4586041f58073552fa2269ac9685c09f6ae2

Diff:

Revision 2 (+17 -10)

Show changes

rbtools/commands/post.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py

Ship it!

rbtools/commands/post.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
% should be on next line.
```
rbtools/commands/post.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
% should be on next line.
```

rbtools/commands/post.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

These parentheses are redundant because of the surrounding parenthesis from CommandError, no?

rbtools/commands/post.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Shouldn't this be on the previous line?
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (94301f5)