Make the --diff-filename and --update flags mutually exclusive.

Review Request #7358 — Created May 31, 2015 and submitted

Information

RBTools
release-0.7.x
c95c458...

Reviewers

When specifying an external diff file, we can't use --update to automatically
guess which review request to update. This change adds a check for that case.

Tried to run with both arguments and saw the error.

Description From Last Updated

% should be on next line.

brenniebrennie

% should be on next line.

brenniebrennie

Why trailing newline?

brenniebrennie

These parentheses are redundant because of the surrounding parenthesis from CommandError, no?

brenniebrennie

Shouldn't this be on the previous line?

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. 
      
brennie
  1. 
      
  2. rbtools/commands/post.py (Diff revision 1)
     
     
    Show all issues

    Why trailing newline?

    1. Many of the others had it. I'll fix them all up.

  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. 
      
brennie
  1. 
      
  2. rbtools/commands/post.py (Diff revisions 1 - 2)
     
     
    Show all issues

    % should be on next line.

  3. rbtools/commands/post.py (Diff revisions 1 - 2)
     
     
    Show all issues

    % should be on next line.

  4. rbtools/commands/post.py (Diff revisions 1 - 2)
     
     
     
     
     
    Show all issues

    These parentheses are redundant because of the surrounding parenthesis from CommandError, no?

  5. rbtools/commands/post.py (Diff revisions 1 - 2)
     
     
    Show all issues

    Shouldn't this be on the previous line?

  6. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (94301f5)