Patch credentials into the git paths when verifying repositories.
Review Request #7356 — Created May 30, 2015 and submitted
If an http(s)-based git repository needs credentials to access, but the user
doesn't want to put the credentials into the URL, it's not possible to add it.
The problem is that even though the repository isn't used to access files
(since we use the raw file URL mask for that), we still try to do
git ls-remoteon it.With this change, if the user added credentials to the admin UI, we'll now
patch those credentials into the URL passed into ls-remote.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Col: 13 W503 line break before binary operator |
 reviewbot
|
|
|
Col: 13 W503 line break before binary operator |
reviewbot
|
|
|
local variable 'result' is assigned to but never used |
reviewbot
|
|
|
Any chance this can be a blank string? Should we just check truthiness? |
 chipx86
|
|
|
Blank line between these. |
chipx86
|
|
|
And these. |
chipx86
|
|
|
""" on the next line. |
chipx86
|
|
|
Remove newline. |
 brennie
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+42 -4) |
-
Tool: Pyflakes Processed Files: reviewboard/scmtools/tests.py reviewboard/scmtools/git.py Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/tests.py reviewboard/scmtools/git.py -
reviewboard/scmtools/tests.py (Diff revision 2) local variable 'result' is assigned to but never used
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+42 -4) |
-
-
reviewboard/scmtools/git.py (Diff revision 3) Any chance this can be a blank string? Should we just check truthiness?
-
-
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+44 -4) |
Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/tests.py reviewboard/scmtools/git.py