Summary

Patch credentials into the git paths when verifying repositories.

Review Request #7356 — Created May 30, 2015 and submitted June 1, 2015, 1:29 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

a0ee8c0...

Reviewers

Groups

reviewboard

People

Description

If an http(s)-based git repository needs credentials to access, but the user
doesn't want to put the credentials into the URL, it's not possible to add it.
The problem is that even though the repository isn't used to access files
(since we use the raw file URL mask for that), we still try to do
git ls-remote on it.

With this change, if the user added credentials to the admin UI, we'll now
patch those credentials into the URL passed into ls-remote.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 13 W503 line break before binary operator	reviewbot	May 30, 2015, 10:49 p.m.
Col: 13 W503 line break before binary operator	reviewbot	May 30, 2015, 10:49 p.m.
local variable 'result' is assigned to but never used	reviewbot	May 30, 2015, 10:50 p.m.
Any chance this can be a blank string? Should we just check truthiness?	chipx86	May 31, 2015, 6:27 p.m.
Blank line between these.	chipx86	May 31, 2015, 6:27 p.m.
And these.	chipx86	May 31, 2015, 6:27 p.m.
""" on the next line.	chipx86	May 31, 2015, 6:28 p.m.
Remove newline.	brennie	June 1, 2015, 1:29 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py

reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 W503 line break before binary operator
```
reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 W503 line break before binary operator
```

Commit:

ca8852801137d80902e46a5f19ecb0f7c9ec5af9

2b79dcb325912d949d50b6b0629e7fd6428a2a13

Diff:

Revision 2 (+42 -4)

Show changes

	reviewboard/scmtools/git.py
	reviewboard/scmtools/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py

reviewboard/scmtools/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 local variable 'result' is assigned to but never used
```

Commit:

2b79dcb325912d949d50b6b0629e7fd6428a2a13

c658d983814c60759528d12ae1d5b0f1a7d3c141

Diff:

Revision 3 (+42 -4)

Show changes

	reviewboard/scmtools/git.py
	reviewboard/scmtools/tests.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py

reviewboard/scmtools/git.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Any chance this can be a blank string? Should we just check truthiness?
```
reviewboard/scmtools/git.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/scmtools/git.py (Diff revision 3)
The issue has been resolved. Show all issues
```
And these.
```
reviewboard/scmtools/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
""" on the next line.
```

Commit:

c658d983814c60759528d12ae1d5b0f1a7d3c141

a0ee8c0be54afed8e3754d99d08d3393c6b82af0

Diff:

Revision 4 (+44 -4)

Show changes

	reviewboard/scmtools/git.py
	reviewboard/scmtools/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/git.py

Ship it!

reviewboard/scmtools/git.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Remove newline.
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (d276d2f)

reviewboard/scmtools/git.py (Diff revision 1)

reviewboard/scmtools/git.py (Diff revision 1)

reviewboard/scmtools/git.py (Diff revision 3)

reviewboard/scmtools/git.py (Diff revision 3)