Convert more spinners to FontAwesome.
Review Request #7344 — Created May 27, 2015 and submitted
This change fixes up the rest of the spinners in the Review Board codebase to
use the FontAwesome "pulse" spinner. The ones in the New Review Request and
Update Diff UIs were replaced, and there were some outdated styles for loading
rich text that had spinners which were no longer used.There are still a couple spinners that still use the old "spinner.gif" in the
Djblets extension and config forms UI. Those will get fixed up in a later
change.
Looked at the New Review Request and Update Diff UIs and verified that all the
spinners looked amazing.
| Description | From | Last Updated |
|---|---|---|
|
Instead of repeating this, should we just have a mixin? Also, rather than <div>, we should probably use a class … |
 chipx86
|
-
-
reviewboard/static/rb/css/pages/reviews.less (Diff revision 1) Instead of repeating this, should we just have a mixin?
Also, rather than
<div>, we should probably use a class name, to keep from having unwanted side-effects down the road, and to help keep this readable.
Change Summary:
Extract common CSS into a mixin.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+75 -99) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/pages/newReviewRequest.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/css/mixins/upload-diff.less reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/newReviewRequest/views/commitView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/pages/newReviewRequest.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/css/mixins/upload-diff.less reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/newReviewRequest/views/commitView.js
Change Summary:
Use a class name for spinner rules.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+75 -99) |
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/pages/newReviewRequest.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/css/mixins/upload-diff.less reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/newReviewRequest/views/commitView.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/pages/newReviewRequest.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/css/mixins/upload-diff.less reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/newReviewRequest/views/commitView.js
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/css/pages/newReviewRequest.less Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/commitView.js reviewboard/static/rb/js/newReviewRequest/views/preCommitView.js reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/updateDiffView.js reviewboard/static/rb/css/pages/newReviewRequest.less