Fix trivial publishing and add a unit test for the backend.
Review Request #7336 — Created May 26, 2015 and submitted
This change fixes up the plumbing of the "trivial" option, and adds a new unit
test to verify that publishing a draft with ?trivial=1 does not send an e-mail.
- Configured e-mail with the console backend and checked that publishing with
the box both checked and un-checked did the correct thing. - Turned off e-mail and saw that the check-box no longer appeared, and that
publishing still worked. - Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
This seems better as an assertion, since it shouldn't happen. |
 chipx86
|
-
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1) This seems better as an assertion, since it shouldn't happen.
-
reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1) Is there an issue with this being anything but true or false?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+52 -8) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_review_request_draft.py reviewboard/reviews/models/review_request_draft.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_review_request_draft.py reviewboard/reviews/models/review_request_draft.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/views/reviewRequestEditorView.js
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_review_request_draft.py reviewboard/reviews/models/review_request_draft.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_review_request_draft.py reviewboard/reviews/models/review_request_draft.py reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/views/reviewRequestEditorView.js