Summary

Links can now be serialized by subclasses

Review Request #7333 — Created May 25, 2015 and submitted May 26, 2015, 5:25 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

master

Bugs

Depends On

Blocks

7301

Commit

91380ac...

Reviewers

Groups

djblets

People

Description

The machinery for serializing links has been modified so that its

behvaiour can be changed by subclasses. The get_link_serializer

method takes a field name and returns the appropriate serializing

function for the link. The default function is serialize_link but

subclasses may provide a serialize_fieldname_link method that will be

used instead.

Testing Done

Tested the serialize_fieldname_link behaviour with a resource. It
worked as intended.

Ran unit tests.

Issues

Description	From	Last Updated
Let's make a utility function for this that does this work, so we can reuse it here and maybe in …	chipx86	May 25, 2015, 4:19 p.m.
Col: 42 E225 missing whitespace around operator	reviewbot	May 25, 2015, 4:23 p.m.

Tool: Pyflakes
Processed Files:
    djblets/webapi/resources.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources.py

djblets/webapi/resources.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's make a utility function for this that does this work, so we can reuse it here and maybe in subclasses.
Maybe get_link_serializer? Takes a field name, returns the function to use?

Change Summary:

Move serialize function finding into a method.

Description:

~		The machinery for serializing links has now been moved into the
~		`serialize_link` method, which can be overridden in a child
~		`WebAPIResource`class to change how links are serialized. If a
~		resource only wants a specific link to be serialized differently, a
~		`serialize_fieldname_link` method can be implemented that will override
~		the default `serialize_link` behaviour.
	~	The machinery for serializing links has been modified so that its
	~	behvaiour can be changed by subclasses. The `get_link_serializer`
	~	method takes a field name and returns the appropriate serializing
	~	function for the link. The default function is `serialize_link` but
	~	subclasses may provide a `serialize_fieldname_link` method that will be
	~	used instead.

Commit:

ca322624e75e0089e8ead9f3ba3a920a5e82b3ae

162de4f5d79d817a4379b6f7ed6edd1cfdcba205

Diff:

Revision 2 (+27 -14)

Show changes

djblets/webapi/resources.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources.py

djblets/webapi/resources.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 42
 E225 missing whitespace around operator
```

Change Summary:

PEP8

Commit:

162de4f5d79d817a4379b6f7ed6edd1cfdcba205

03d514a05efb7b76a8847767fc5c246717d7726c

Diff:

Revision 3 (+27 -14)

Show changes

djblets/webapi/resources.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources.py

Commit:

03d514a05efb7b76a8847767fc5c246717d7726c

91380acc425ccb5bacafb3551125e602a079708e

Diff:

Revision 4 (+26 -13)

Show changes

djblets/webapi/resources.py

Tool: Pyflakes
Processed Files:
    djblets/webapi/resources.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (c33bd0d)