Add review request IDs to the depends_on and blocks API fields

Review Request #7301 — Created May 13, 2015 and submitted

Information

Review Board
release-2.5.x
e7b317f...

Reviewers

The links generated for the depends_on and blocks fields of the
ReviewRequestAPIResource and ReviewRequestDraftResource now contain
the ID of the review request of that is being linked to.

Ran unit tests.

Verified that the new behaviour does not override the ?expand=
behaviour.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/review_request.py
    
    
  2. 
      
brennie
chipx86
  1. I think this breaks expanding of the resources? I think what we need is a new mechanism for serializing a link for a field, instead of the payload body.

    1. So it does. I'm going to have to rethink how this is done.

  2. 
      
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/review_request.py
    
    
  2. 
      
chipx86
  1. Soooo much nicer :)

  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (43d9bda)