Summary

Add review request IDs to the depends_on and blocks API fields

Review Request #7301 — Created May 13, 2015 and submitted May 26, 2015, 5:25 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

3863

Depends On

~~7333~~

Commit

e7b317f...

Reviewers

Groups

reviewboard

People

Description

The links generated for the depends_on and blocks fields of the
ReviewRequestAPIResource and ReviewRequestDraftResource now contain
the ID of the review request of that is being linked to.

Testing Done

Ran unit tests.

Verified that the new behaviour does not override the ?expand=
behaviour.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_request.py

Change Summary:

Add issue number.

Bugs:

+	3863

I think this breaks expanding of the resources? I think what we need is a new mechanism for serializing a link for a field, instead of the payload body.

brennie May 14, 2015, 8:35 p.m.

So it does. I'm going to have to rethink how this is done.

Summary:

-	Add review request IDs to the depends_on and blocks API fields
+	[WIP] Add review request IDs to the depends_on and blocks API fields

Summary:

-	[WIP] Add review request IDs to the depends_on and blocks API fields
+	Add review request IDs to the depends_on and blocks API fields

Testing Done:

		Ran unit tests.
	+
	+	Verified that the new behaviour does not override the `?expand=`
	+	behaviour.

Branch:

-	master
+	release-2.5.x

Depends On:

+	~~7333 - Links can now be serialized by subclasses~~

Commit:

-	fbc75832750d3671c371ad81245ff872cbe2a903
+	e7b317f4571026aecaaefe05110185040d3a5f2a

Diff:

Revision 2 (+10)

Show changes

reviewboard/webapi/resources/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_request.py

Ship it!

```
Soooo much nicer :)
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (43d9bda)