Summary

Refactor the land command.

Review Request #7329 — Created May 22, 2015 and submitted May 25, 2015, 4:10 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

f586705...

Reviewers

Groups

rbtools

People

Description

The rbt land command has been refactored so that the core
functionality of landing a review request onto a branch now lies in
the Land.land method. This results in simplified logic in the main
method and sets up for recursive landing support in a future patch.

Testing Done

Ran unit tests.

Successfully landed review requests using both a source branch and a
review request ID.

Issues

Description	From	Last Updated
This doesn't seem correct. The previous code had it overwriting is_local only when self.options.is_local was provided. Now it sets it …	david	May 25, 2015, 3:19 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/land.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/land.py

rbtools/commands/land.py (Diff revision 1)

The issue has been resolved. Show all issues

This doesn't seem correct. The previous code had it overwriting is_local only when self.options.is_local was provided. Now it sets it in the blocks above and then unconditionally overwrites it here.

Change Summary:

Address David's issues.

Commit:

066461763b61bcfc90e5c12e9c1c8fd1a62eac4a

f58670579c1c04543b364a44e4415262e21dbed6

Diff:

Revision 2 (+158 -159)

Show changes

rbtools/commands/land.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/land.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/land.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0012ffc)