Refactor the land command.
Review Request #7329 — Created May 22, 2015 and submitted
The
rbt land
command has been refactored so that the core
functionality of landing a review request onto a branch now lies in
theLand.land
method. This results in simplified logic in themain
method and sets up for recursive landing support in a future patch.
Ran unit tests.
Successfully landed review requests using both a source branch and a
review request ID.
Description | From | Last Updated |
---|---|---|
This doesn't seem correct. The previous code had it overwriting is_local only when self.options.is_local was provided. Now it sets it … |
david |
-
-
rbtools/commands/land.py (Diff revision 1) This doesn't seem correct. The previous code had it overwriting
is_local
only whenself.options.is_local
was provided. Now it sets it in the blocks above and then unconditionally overwrites it here.
Change Summary:
Address David's issues.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+158 -159) |