Refactor DiffSetTests
Review Request #7324 — Created May 21, 2015 and submitted
The common functionality of each test in the DiffSetTests class has
been refactored into asetUpmethod to remove code duplication.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Should be DiffCommit.objects.create(...) |
 chipx86
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+25 -36) |
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/tests.py
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+24 -35) |
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/tests.py
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+22 -38) |
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/tests.py
Change Summary:
Use
DiffCommit.objects.createinstead ofDiffCommit().save()
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+25 -45) |
Tool: Pyflakes Processed Files: reviewboard/diffviewer/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/tests.py