Refactor DiffSetTests
Review Request #7324 — Created May 21, 2015 and submitted
The common functionality of each test in the DiffSetTests class has
been refactored into asetUp
method to remove code duplication.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
Should be DiffCommit.objects.create(...) |
chipx86 |
- Commit:
-
ae5b8944e005e10268e5b7fde3c3937c22c24ed551cbca559d69bbc3cfab0f6874e1c9be494b4ace
- Diff:
-
Revision 2 (+25 -36)
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/tests.py
- Commit:
-
51cbca559d69bbc3cfab0f6874e1c9be494b4ace5a3ff4c7e85f45a9423ecaf072cde917310ff586
- Diff:
-
Revision 3 (+24 -35)
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/tests.py
- Commit:
-
5a3ff4c7e85f45a9423ecaf072cde917310ff586f2f8d369a734081cd6a0b2929032fb471678050c
- Diff:
-
Revision 4 (+22 -38)
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/tests.py
- Change Summary:
-
Use
DiffCommit.objects.create
instead ofDiffCommit().save()
- Commit:
-
f2f8d369a734081cd6a0b2929032fb471678050ceea7dc8afeeb1f950f183e9d95202c526636b3d2
- Diff:
-
Revision 5 (+25 -45)