Summary

Serialize commit ID to the DiffCommit js model

Review Request #7319 — Created May 20, 2015 and submitted May 20, 2015, 1:49 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

3b72076...

Reviewers

Groups

reviewboard

People

Description

The DiffViewerView previously did not serialize the commit IDs of the
commits it was sending. This has been rectified so that the commit ID
attribute can be read from JavaScript. The commitId attribute has
also been renamed to commitID.

Testing Done

Verified the commitID attribute is accessible from the DiffCommit
model.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/views.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/views.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (50c4ddd)