Change some option names and descriptions for consistency.

Review Request #7312 — Created May 18, 2015 and submitted

Information

RBTools
release-0.7.x
2cf67c6...

Reviewers

RBTools 0.7.3 added a number of new options, both on the command line
and in RBClient, for controlling cache and SSL verification behavior.
This change standardizes the names a bit to keep them consistent, and
reorders them in the help output to be closer together.

The --in-memory-cache option is now --disable-cache-storage.
--dont-save-credentials is now -disable-cookie-storage, to
match. All the various "disable" options are now grouped together after
the authentication settings.

RBClient was updated to take verify_ssl= instead of
disable_ssl_verification=, to help keep most options positive
instead of negative.

Saw the new output. Posted changes without any errors.

Ran unit tests. They passed, except for one that was already broken.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (6a53837)
gmyers
  1. Sorry, I'm a little late to the party. This is probably not be the best place, but I'll also throw in here that -s/--stamp was added to post.py during this dev cycle, but it is missing an added_in field.

  2. rbtools/commands/__init__.py (Diff revision 1)
     
     
    Should this be 0.7.3?
  3. 
      
Loading...