Calculation of SESSION_COOKIE_AGE = 1 year is incorrect

 






 

 


  Review Request #731
  —
  Created Feb. 1, 2009 and submitted

 


















 

  

   Information

  





 
 

  UGdZ4Go4
 









 
 

  Review Board SVN (deprecated)
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The math used to compute 1 year in seconds is incorrect.  There are 60 minutes in an hour, not 24.


 








  


 
 

  
Code inspection.

According to this page:
  http://www.djangoproject.com/documentation/0.96/settings/#session-cookie-age
The SESSION_COOKIE_AGE option is in seconds.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Good catch! Thanks! Committed as r1734.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...