Don't crash if old repositories don't work.

Review Request #7309 — Created May 16, 2015 and submitted

Information

RBTools
release-0.7.x
22e1f1a...

Reviewers

In the SVN backend, we iterate through all repositories trying to match on
UUID. This fails if there's an old repository configured which cannot be
accessed. This change adds a try/except to pass over any errors.

Ran unit tests.

Description From Last Updated

We should probably check for the specific error code, and log anything else.

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
    
    
  2. 
      
chipx86
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 1)
     
     
     
    Show all issues

    We should probably check for the specific error code, and log anything else.

    1. In this case, I don't think it really matters. We're just scanning through everything to see if there's an ideal match. If there are substantive errors, they'll happen later on when actually posting.

  3. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (e38048f)
Loading...