Only show history entry symbol in commit diffs

Review Request #7303 — Created May 15, 2015 and submitted

Information

Review Board
dvcs
471f5ca...

Reviewers

The history entry symbol (e.g., + or -) column is now only shown in
the DiffCommitIndexView when there is a commit history diff to show.
This results in less whitespace on the left hand side of the table and
the diff complexity icons will align with those in the
DiffFileIndexView.

Verified the extra column is not shown when there is no commit diffing
being done, or when the two histories are identical.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    
    
  2. 
      
brennie
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (fe48626)
Loading...