Summary

Only show history entry symbol in commit diffs

Review Request #7303 — Created May 15, 2015 and submitted May 15, 2015, 11:48 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

471f5ca...

Reviewers

Groups

reviewboard

People

Description

The history entry symbol (e.g., + or -) column is now only shown in
the DiffCommitIndexView when there is a commit history diff to show.
This results in less whitespace on the left hand side of the table and
the diff complexity icons will align with those in the
DiffFileIndexView.

Testing Done

Verified the extra column is not shown when there is no commit diffing
being done, or when the two histories are identical.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js

Testing Done:: ~
Verified the extra column is not shownwhen there is no commit diffing
~
Verified the extra column is not shown when there is no commit diffing
being done, or when the two histories are identical.

Change Summary:

Remove console.log call

Commit:

f84bc7e3e818e0db48dfea94fdd2cc39ecdd0015

471f5ca52fb6af534e51fc5c9cfb666135184432

Diff:

Revision 2 (+21 -4)

Show changes

reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (fe48626)

~		Verified the extra column is not shownwhen there is no commit diffing
	~	Verified the extra column is not shown when there is no commit diffing
		being done, or when the two histories are identical.