Only render visibility for authenticated users

Review Request #7302 — Created May 15, 2015 and submitted

Information

Review Board
release-2.5.x
d4a9d62...

Reviewers

Previously, when an unauthenticated user attempted to view the 'All
Review Requests' page, every summary would be None. This was because
the SummaryColumn would attempt to evalute the
review_request.visibility attribute, but it is only defined when the
user is authenticated. This would lead to an exception being raised in
the rendering and None being returned instead. This patch fixes the
issue by only attempting to render the review request visibility when
the user viewing the datagrid is authenticated.

The archived and muted state is correctly shown.

The summaries are correctly rendered in the datagrid.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/columns.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/columns.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (8ac63b5)
Loading...