Summary

Add support for an in-memory cookie store

Review Request #7295 — Created May 8, 2015 and submitted May 13, 2015, 1:40 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Commit

a2b942e...

Reviewers

Groups

rbtools

People

Description

There is now support for an in-memory cookie store. This feature can be
enabled via the --in-memory-cookies command-line option. For
consumers of the API, passing in_memory_cookies=True to the RBClient
constructor will enable this behaviour as well.

Testing Done

Ran unit tests.

Updated this review request with the --in-memory-cookies flag. I was
prompted for my username and password. When updating without the flag,
I am not prompted.

Issues

Description	From	Last Updated
Do we want a config key for this?	david	May 11, 2015, 2:58 p.m.
"instead of writing them to a file"	chipx86	May 11, 2015, 6:10 p.m.
Alphabetical order.	chipx86	May 13, 2015, 1:37 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

Summary:

-	Add support for an in-memory cookie store.
+	Add support for an in-memory cookie store

rbtools/commands/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

Do we want a config key for this?

david May 9, 2015, 8:27 p.m.

Oh, also, is this really the best UI? Maybe something like --dont-save-credentials?

Commit:

-	bc30734227fd0e578ebf77a2b601407e27ee45af
+	478ebf9d26af04607758894f299bfe91144c7458

Diff:

Revision 2 (+41 -17)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

How about simplifying the terminology/variables a bit, and calling them "save_cookies" and "no-save-cookies"?

chipx86 May 15, 2015, 6:47 p.m.

Oops, I guess the --no-save-cookies part didn't happen. Didn't notice when I first reviewed.

rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"instead of writing them to a file"
```

Change Summary:

Address Christian's issues.

Change to use save_cookies instead of in_memory_cookies or save_credentials.

Commit:

-	478ebf9d26af04607758894f299bfe91144c7458
+	54666c5fcd1381da79046b49b219c6b126f610d1

Diff:

Revision 3 (+41 -17)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

Ship it!

rbtools/api/request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Alphabetical order.
```

Branch:

-	master
+	release-0.7.x

Commit:

-	54666c5fcd1381da79046b49b219c6b126f610d1
+	a2b942ecaf869953824d81eaa9180ded60fecf8a

Diff:

Revision 4 (+40 -17)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (422ab0e)