Fix git-svn and git-p4 to process diffs as byte strings.

Review Request #7291 — Created May 7, 2015 and submitted

Information

RBTools
release-0.7.x
fb42432...

Reviewers

We had previously changed the git diff processing to do everything as bytes,
but the make_svn_diff and make_perforce_diff methods weren't updated, and
as a result we were coercing bytes to strings, and failing if there were any
non-ASCII characters. This change updates those methods to do everything as
bytes.

Ran unit tests.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/git.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (219abf7)
Loading...