Ensure we always show a retina version of file attachment thumbnails.
Review Request #7284 — Created May 2, 2015 and submitted
Loading of file attachment thumbnails can sometimes be racy with regards to
retina.js. In particular, if we finish loading everything before the window's
onloadevent fires, retina.js will happily process all the images and show
the at2x versions. If not (and for file attachments created via drag-and-drop),
it never processes them.This change updates the
FileAttachmentThumbnailViewto manually create a
RetinaImage, and remove thedata-at2xattribute (so that theonload
handler won't process them).
Uploaded new file attachments and saw the high-res version of the thumbnail.
| Description | From | Last Updated |
|---|---|---|
|
You can avoid the need for self above by doing: _.each(this._$thumbnailContainer.find('img'), function(el) { ... }, this); |
 chipx86
|
-
-
reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js (Diff revision 1) You can avoid the need for
selfabove by doing:_.each(this._$thumbnailContainer.find('img'), function(el) { ... }, this);
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+7) |
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js