Summary

Fix some issues in the DiffProcessor

Review Request #7267 — Created April 29, 2015 and submitted May 4, 2015, 11:49 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Commit

abca9da...

Reviewers

Groups

reviewboard

People

Description

This patch fixes the DiffProcessor to correctly use the provided file
existence checker intsead of always checking in the repository. It also
fixes an error in the _compare_files method that was a result of
refactoring.

Testing Done

Ran unit tests.

Now able to validate diff commits correctly.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/managers.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/managers.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (56b865f)