Make `SCMTool.get_file()` take `base_commit_id`.
Review Request #7265 — Created April 29, 2015 and submitted
All SCMTool implementations should now take keyword arguments and a
base_commit_id argument. All internal implementations have been
converted and third party tools will cause a deprecation warning if
they do not have the proper method signature.The HgTool now takes advantage of this `base_commit_id` argument when
fetching files (since hg git diffs do not include index lines which
we use to determine what revisions to fetch). If `base_commit_id` is
provided it will override anything parsed from the diff.The same applies to SCMTool.file_exists()
New tests, unit tests pass, posted hg diff now uses the provided base_commit_id.
Description | From | Last Updated |
---|---|---|
're' imported but unused |
reviewbot | |
Single quotes. |
brennie | |
Single quotes. |
brennie | |
'FileNotFoundError' imported but unused |
reviewbot | |
No need for parens here. |
chipx86 | |
local variable 'new_changeset_id' is assigned to but never used |
reviewbot | |
local variable 'orig_changeset_id' is assigned to but never used |
reviewbot | |
Col: 17 E221 multiple spaces before operator |
reviewbot | |
Col: 21 E221 multiple spaces before operator |
reviewbot | |
We could probably make this a utility function, cutting down this code a lot and making it more reusable. Another … |
chipx86 | |
Col: 17 E221 multiple spaces before operator |
reviewbot | |
Col: 17 E221 multiple spaces before operator |
reviewbot | |
'warnings' imported but unused |
reviewbot |
-
Should probably have unit tests for the warning behavior and changes in the hg handling of the parameters.
Also, I imagine we need this for
file_exists
as well. -
Change Summary:
Addressed feedback - tests, file_exists fixed.
Description: |
|
||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+148 -40) |
-
Tool: Pyflakes Processed Files: reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py
-
reviewboard/scmtools/hg.py (Diff revision 2) local variable 'new_changeset_id' is assigned to but never used
-
reviewboard/scmtools/hg.py (Diff revision 2) local variable 'orig_changeset_id' is assigned to but never used
-
Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py
-
-
Change Summary:
Review Bot fixups.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+148 -40) |
-
Tool: Pyflakes Processed Files: reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py
-
-
reviewboard/scmtools/tests.py (Diff revision 3) We could probably make this a utility function, cutting down this code a lot and making it more reusable.
Another interesting idea is adding an
assertWarns
in the base TestCase.
Change Summary:
Fiuxed issue.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+163 -40) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/testing/testcase.py reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py
-
-
Change Summary:
Fixed PEP8. Apparently I like to hit the spacebar too much :P
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+163 -40) |
-
Tool: Pyflakes Processed Files: reviewboard/testing/testcase.py reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/testcase.py reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+162 -40) |
-
Tool: Pyflakes Processed Files: reviewboard/testing/testcase.py reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/testcase.py reviewboard/scmtools/clearcase.py reviewboard/scmtools/mtn.py reviewboard/scmtools/git.py reviewboard/scmtools/hg.py reviewboard/scmtools/localfile.py reviewboard/scmtools/core.py reviewboard/scmtools/perforce.py reviewboard/scmtools/bzr.py reviewboard/scmtools/cvs.py reviewboard/scmtools/plastic.py reviewboard/scmtools/tests.py reviewboard/testing/scmtool.py reviewboard/scmtools/svn/__init__.py reviewboard/scmtools/models.py