Better linking in the UI Adding link icons to review comments.
Review Request #7254 — Created April 26, 2015 and discarded
Add icons to link to review comments and replies.
Manual testing:
- Clicking the link icon brings you to the link for the comment associated with it.
| Description | From | Last Updated |
|---|---|---|
|
This <li> should only be indented one space from the <ul>. Make sure to indent with spaces and not tabs. … |
 brennie
|
|
|
This change looks unintentional. |
 david
|
|
|
There's still an unintentional change to this file (you dedented this line by 1 space). |
david
|
|
|
This is duplicating the comment text. I think you just want to add the span/a/i next to the existing comment … |
david
|
-
Can you upload some screenshots for this change?
-
reviewboard/templates/reviews/review_reply_section.html (Diff revision 1) This
<li>should only be indented one space from the<ul>. Make sure to indent with spaces and not tabs.Also, can we use a Can you use a
<span>for the icon?Finally, can you give the
<span>atitle=attribute that describes the action of the icon (e.g., "Link to here"). Make sure to use i18n.
TE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+663 -211) |
-
Tool: Pyflakes Processed Files: reviewboard/diffviewer/chunk_generator.py reviewboard/accounts/pages.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py reviewboard/staticbundles.py reviewboard/accounts/tests.py Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/templates/reviews/table_comment_issue.html reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/commentIssueBarView.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/headerView.js reviewboard/static/rb/js/views/tests/commentIssueBarViewTests.js reviewboard/static/rb/css/common.less reviewboard/templates/reviews/diff_comment_fragment.html reviewboard/templates/reviews/review_issue_summary_table.html reviewboard/static/rb/css/pages/dashboard.less Tool: PEP8 Style Checker Processed Files: reviewboard/diffviewer/chunk_generator.py reviewboard/accounts/pages.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py reviewboard/staticbundles.py reviewboard/accounts/tests.py Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/templates/reviews/table_comment_issue.html reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/js/views/commentIssueBarView.js reviewboard/static/rb/css/ui/datagrids.less reviewboard/static/rb/css/pages/reviews.less reviewboard/static/rb/js/views/issueSummaryTableView.js reviewboard/static/rb/js/views/headerView.js reviewboard/static/rb/js/views/tests/commentIssueBarViewTests.js reviewboard/static/rb/css/common.less reviewboard/templates/reviews/diff_comment_fragment.html reviewboard/templates/reviews/review_issue_summary_table.html reviewboard/static/rb/css/pages/dashboard.less
TE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+29 -2) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less Tool: Pyflakes Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less
-
-
reviewboard/templates/reviews/review_reply_section.html (Diff revision 3) This change looks unintentional.
TE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+27 -1) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less Tool: Pyflakes Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less
-
-
reviewboard/templates/reviews/review_reply_section.html (Diff revision 4) There's still an unintentional change to this file (you dedented this line by 1 space).
TE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+26) |
-
Tool: Pyflakes Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less
-
-
reviewboard/templates/reviews/boxes/review.html (Diff revision 5) This is duplicating the comment text. I think you just want to add the span/a/i next to the existing comment down on line 159. You should also change the
<i>to be a<span>, and can put the title attribute on the<a>rather than making another element.
TE
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+26 -1) |
-
Tool: Pyflakes Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less
-
So the code is looking better now. I notice that you still have "WIP" in the summary--is there more work that you were planning on doing for this?
Tool: Pyflakes Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/reviews/review_reply_section.html reviewboard/static/rb/css/pages/reviews.less