Better linking in the UI Adding link icons to review comments.

Review Request #7254 - Created April 26, 2015 and discarded

Teresa Fan
Review Board
master
reviewboard, students

Add icons to link to review comments and replies.

Manual testing:
- Clicking the link icon brings you to the link for the comment associated with it.

Loading file attachments...

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
Barret Rennie
  1. Can you upload some screenshots for this change?

    1. Sure, although the main reason that I didn't was that Christian already gave me some feedback from the ones I shared on Slack and suggested a different place for the icons, which isn't reflected in this change yet.

  2. This <li> should only be indented one space from the <ul>. Make sure to indent with spaces and not tabs.

    Also, can we use a Can you use a <span> for the icon?

    Finally, can you give the <span> a title= attribute that describes the action of the icon (e.g., "Link to here"). Make sure to use i18n.

  3. 
      
Teresa Fan
Teresa Fan
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/accounts/pages.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/staticbundles.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/templates/reviews/table_comment_issue.html
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/js/views/commentIssueBarView.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/views/issueSummaryTableView.js
        reviewboard/static/rb/js/views/headerView.js
        reviewboard/static/rb/js/views/tests/commentIssueBarViewTests.js
        reviewboard/static/rb/css/common.less
        reviewboard/templates/reviews/diff_comment_fragment.html
        reviewboard/templates/reviews/review_issue_summary_table.html
        reviewboard/static/rb/css/pages/dashboard.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/chunk_generator.py
        reviewboard/accounts/pages.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/staticbundles.py
        reviewboard/accounts/tests.py
    
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/templates/reviews/table_comment_issue.html
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/js/views/commentIssueBarView.js
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/views/issueSummaryTableView.js
        reviewboard/static/rb/js/views/headerView.js
        reviewboard/static/rb/js/views/tests/commentIssueBarViewTests.js
        reviewboard/static/rb/css/common.less
        reviewboard/templates/reviews/diff_comment_fragment.html
        reviewboard/templates/reviews/review_issue_summary_table.html
        reviewboard/static/rb/css/pages/dashboard.less
    
    
  2. 
      
Teresa Fan
Teresa Fan
Review Bot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
Teresa Fan
David Trowbridge
  1. 
      
  2. This change looks unintentional.

  3. 
      
Teresa Fan
Review Bot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/review_reply_section.html
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. There's still an unintentional change to this file (you dedented this line by 1 space).

  3. 
      
Teresa Fan
Review Bot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. This is duplicating the comment text. I think you just want to add the span/a/i next to the existing comment down on line 159. You should also change the <i> to be a <span>, and can put the title attribute on the <a> rather than making another element.

    1. Such a silly error, sorry about that!

  3. 
      
Teresa Fan
Review Bot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
David Trowbridge
  1. So the code is looking better now. I notice that you still have "WIP" in the summary--is there more work that you were planning on doing for this?

    1. Nope, unless there's something else I could do. I just forgot to change the summary, it's fixed now.

  2. 
      
Teresa Fan
Christian Hammond
Review request changed

Status: Discarded

Change Summary:

Superceded by https://reviews.reviewboard.org/r/9184/

Loading...