Use babel to run ES6 on the server.

Review Request #7246 — Created April 23, 2015 and submitted

david
student-sonar
master
db0528d...
student-sonar

We already have ES6 on the client courtesy of traceur, but not on the server.
Babel provides a node wrapper that will precompile everything, allowing much
of the server-side code to use handy features like let and arrow functions.

Verified that everything still works on both dev and production.

Description From Last Updated

let

brenniebrennie

let

brenniebrennie

let

brenniebrennie

let

brenniebrennie

let

brenniebrennie

Can we use let ... of here?

brenniebrennie

Can we use let ... of here?

brenniebrennie

let

brenniebrennie

Blank line between these.

brenniebrennie

Is it worth it to use a => function here?

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        lib/config.js
        package.json
        server.js
        bin/load-slack-users
        lib/students.js
        bin/add-calendar-entry
        lib/init.js
        lib/reviewboard.js
        lib/routes.js
        README.md
        lib/slack.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        lib/config.js
        package.json
        server.js
        bin/load-slack-users
        lib/students.js
        bin/add-calendar-entry
        lib/init.js
        lib/reviewboard.js
        lib/routes.js
        README.md
        lib/slack.js
    
    
  2. 
      
brennie
  1. 
      
  2. bin/add-calendar-entry (Diff revision 1)
     
     
  3. bin/load-slack-users (Diff revision 1)
     
     
  4. bin/load-slack-users (Diff revision 1)
     
     
  5. bin/load-slack-users (Diff revision 1)
     
     
  6. bin/load-slack-users (Diff revision 1)
     
     
  7. bin/load-slack-users (Diff revision 1)
     
     

    Can we use let ... of here?

    1. A map would be even better.

  8. lib/config.js (Diff revision 1)
     
     
     
     
     
     

    Can we use let ... of here?

    1. for..of only gives us the values, and we need both key and value.

  9. server.js (Diff revision 1)
     
     
  10. server.js (Diff revision 1)
     
     

    Blank line between these.

  11. server.js (Diff revision 1)
     
     

    Is it worth it to use a => function here?

    1. Actually nevermind.

  12. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        lib/config.js
        package.json
        server.js
        bin/load-slack-users
        lib/students.js
        bin/add-calendar-entry
        lib/init.js
        lib/reviewboard.js
        lib/routes.js
        README.md
        lib/slack.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        lib/config.js
        package.json
        server.js
        bin/load-slack-users
        lib/students.js
        bin/add-calendar-entry
        lib/init.js
        lib/reviewboard.js
        lib/routes.js
        README.md
        lib/slack.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (0ba6c3f)
Loading...