Summary

Use babel to run ES6 on the server.

Review Request #7246 — Created April 24, 2015 and submitted April 24, 2015, 8:39 p.m.

Information

Owner

david

Repository

student-sonar

Branch

master

Bugs

Depends On

Commit

db0528d...

Reviewers

Groups

student-sonar

People

Description

We already have ES6 on the client courtesy of traceur, but not on the server.

Babel provides a node wrapper that will precompile everything, allowing much

of the server-side code to use handy features like let and arrow functions.

Testing Done

Verified that everything still works on both dev and production.

Issues

Description	From	Last Updated
let	brennie	April 24, 2015, 1:48 a.m.
let	brennie	April 24, 2015, 1:51 a.m.
let	brennie	April 24, 2015, 1:51 a.m.
let	brennie	April 24, 2015, 1:51 a.m.
let	brennie	April 24, 2015, 1:52 a.m.
Can we use let ... of here?	brennie	April 24, 2015, 1:52 a.m.
Can we use let ... of here?	brennie	April 24, 2015, 1:52 a.m.
let	brennie	April 24, 2015, 1:53 a.m.
Blank line between these.	brennie	April 24, 2015, 1:53 a.m.
Is it worth it to use a => function here?	brennie	April 24, 2015, 1:42 a.m.

Tool: PEP8 Style Checker
Ignored Files:
    lib/config.js
    package.json
    server.js
    bin/load-slack-users
    lib/students.js
    bin/add-calendar-entry
    lib/init.js
    lib/reviewboard.js
    lib/routes.js
    README.md
    lib/slack.js



Tool: Pyflakes
Ignored Files:
    lib/config.js
    package.json
    server.js
    bin/load-slack-users
    lib/students.js
    bin/add-calendar-entry
    lib/init.js
    lib/reviewboard.js
    lib/routes.js
    README.md
    lib/slack.js

bin/add-calendar-entry (Diff revision 1)
The issue has been resolved. Show all issues
```
let
```
bin/load-slack-users (Diff revision 1)
The issue has been resolved. Show all issues
```
let
```
bin/load-slack-users (Diff revision 1)
The issue has been resolved. Show all issues
```
let
```
bin/load-slack-users (Diff revision 1)
The issue has been resolved. Show all issues
```
let
```
bin/load-slack-users (Diff revision 1)
The issue has been resolved. Show all issues
```
let
```
bin/load-slack-users (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we use let ... of here?
```
1. david
  
  April 24, 2015, 2:09 a.m.
  A map would be even better.

lib/config.js (Diff revision 1)

The issue has been dropped. Show all issues

Can we use let ... of here?

david

April 24, 2015, 2:09 a.m.

for..of only gives us the values, and we need both key and value.

server.js (Diff revision 1)
The issue has been resolved. Show all issues
```
let
```
server.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
server.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Is it worth it to use a => function here?
```
1. brennie
  
  April 24, 2015, 1:42 a.m.
  Actually nevermind.

Commit:

69697fb1110ba18e43ace67b2086943874c3b07e

db0528d3e688dfa0c404e631e1b4f5eef8f845cc

Diff:

Revision 2 (+76 -88)

Show changes

	README.md
	package.json
	server.js
	bin/add-calendar-entry
	bin/load-slack-users
	lib/config.js
	lib/init.js
	lib/reviewboard.js
	3 more

Tool: PEP8 Style Checker
Ignored Files:
    lib/config.js
    package.json
    server.js
    bin/load-slack-users
    lib/students.js
    bin/add-calendar-entry
    lib/init.js
    lib/reviewboard.js
    lib/routes.js
    README.md
    lib/slack.js



Tool: Pyflakes
Ignored Files:
    lib/config.js
    package.json
    server.js
    bin/load-slack-users
    lib/students.js
    bin/add-calendar-entry
    lib/init.js
    lib/reviewboard.js
    lib/routes.js
    README.md
    lib/slack.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0ba6c3f)