Update the mobile page menu and header to work with page themes.

Review Request #7244 — Created April 23, 2015 and submitted

Information

Review Board
release-2.5.x
c850fe9...

Reviewers

The header and slide-out menu now match the page's theme, providing a
consistent look on smaller devices. This works for all pages that
provide such a menu.

I've also fixed showing the page mask on the dashboard, fixed the
z-indexes for the mobile menu and mask, and added a transition when
showing/hiding the mask.

Tested the dashboard, review request, and administration pages in a mobile
mode. They all looked as expected (aside from the administration page, which
has some existing visual quirks apparently unrelated to this work).


reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/base.html
        reviewboard/templates/base/headerbar.html
        reviewboard/static/rb/css/mixins/theme.less
        reviewboard/static/rb/css/pages/base.less
        reviewboard/static/rb/js/views/headerView.js
        reviewboard/static/rb/css/defs.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/base.html
        reviewboard/templates/base/headerbar.html
        reviewboard/static/rb/css/mixins/theme.less
        reviewboard/static/rb/css/pages/base.less
        reviewboard/static/rb/js/views/headerView.js
        reviewboard/static/rb/css/defs.less
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (ca30992)
Loading...