Summary

Ensure interdiffs do not update line counts

Review Request #7241 — Created April 23, 2015 and submitted April 23, 2015, 12:49 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

7a35a58...

Reviewers

Groups

reviewboard

People

Description

Previously it was possible for the DiffChunkGenerator to update the
line counts in a forced interdiff (i.e., an interdiff where there is no
corresponding interfilediff, such as when the changes to a file are
reverted). This results in all insert and delete counts being swapped
in the FileDiff's line counts. This patch fixes this issue.

A unit test was added to ensure that this does not regress.

Testing Done

Ran unit tests.
The new unit test failed without the patch applied.

Issues

Description	From	Last Updated
""" on the next line.	chipx86	April 23, 2015, 12:44 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py

Ship it!

reviewboard/diffviewer/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
""" on the next line.
```

Branch:

master

release-2.5.x

Commit:

17519151a19e7fc5f0a0a635da624d908be8bee7

7a35a58b33618ffc249d6a53cb375cd756b3e13e

Diff:

Revision 2 (+31 -1)

Show changes

	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/chunk_generator.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (ca08db7)