Add sessions and login with slack.

Review Request #7237 — Created April 22, 2015 and submitted

david
student-sonar
master
7d5b853...
student-sonar

This change adds access control to sonar, using Slack OAuth as a login
provider. This uses the 'passport' framework to handle the guts, and the
passport-slack provider to talk to Slack itself. Sessions are stored in
mongodb.

Logged in and out a whole bunch.

Description From Last Updated

It seems to me that the session secret should be read in with the rest of the config.

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        lib/config.js
        package.json
        server.js
        views/student-list.handlebars
        views/login.handlebars
        lib/schema.js
        images/slack-logo.png
        style.css
        lib/routes.js
        views/layouts/main.handlebars
    
    
    
    Tool: Pyflakes
    Ignored Files:
        lib/config.js
        package.json
        server.js
        views/student-list.handlebars
        views/login.handlebars
        lib/schema.js
        images/slack-logo.png
        style.css
        lib/routes.js
        views/layouts/main.handlebars
    
    
  2. 
      
brennie
  1. 
      
  2. server.js (Diff revision 1)
     
     

    It seems to me that the session secret should be read in with the rest of the config.

    1. You sir are wise beyond your years.

  3. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        lib/config.js
        package.json
        server.js
        views/student-list.handlebars
        views/login.handlebars
        lib/schema.js
        images/slack-logo.png
        style.css
        lib/routes.js
        views/layouts/main.handlebars
    
    
    
    Tool: Pyflakes
    Ignored Files:
        lib/config.js
        package.json
        server.js
        views/student-list.handlebars
        views/login.handlebars
        lib/schema.js
        images/slack-logo.png
        style.css
        lib/routes.js
        views/layouts/main.handlebars
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (c6cc101)
Loading...