Summary

Add the rbt alias command

Review Request #7234 — Created April 21, 2015 and submitted April 23, 2015, 2:37 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

~~7232~~, ~~7233~~

Commit

1b96916...

Reviewers

Groups

rbtools

People

Description

The rbt alias command is a new command for manging your aliases
defined in .reviewboardrc files. It currently has the capability to
list all defined aliases, via rbt alias --list, and to do a "dry run"
of a command, via rbt alias --dry-run <ALIAS>.

The alias listing will show what files aliases are defined in, as well
as if they are overridden by other aliases or rbt commands (defined
by entry points or the presence of an rbt-command-name executable).

Some refactoring has been done to the rbtools.comands module to
handle command detection so that it can be reused by the new command.
Refactoring has also been performed on the rbtools.utils.aliases
module to allow aliases to be expanded without being ran.

Testing Done

Ran unit tests.

Tested the rbt alias --list and rbt alias --dry-run commands.
They work as expected.

Issues

Description	From	Last Updated
Add period at end of help string.	gmyers	April 22, 2015, 12:56 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/utils/testbase.py
    rbtools/commands/alias.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/tests.py
    rbtools/utils/filesystem.py
    setup.py
    rbtools/utils/aliases.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/testbase.py
    rbtools/commands/alias.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/tests.py
    rbtools/utils/filesystem.py
    setup.py
    rbtools/utils/aliases.py

Change Summary:

Rebased off updated r/7232

Diff:

Revision 2 (+185 -49)

Show changes

	setup.py
	rbtools/clients/tests.py
	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/main.py
	rbtools/utils/aliases.py
	rbtools/utils/filesystem.py
	rbtools/utils/testbase.py

Tool: Pyflakes
Processed Files:
    rbtools/utils/testbase.py
    rbtools/commands/alias.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/tests.py
    rbtools/utils/filesystem.py
    setup.py
    rbtools/utils/aliases.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/testbase.py
    rbtools/commands/alias.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/tests.py
    rbtools/utils/filesystem.py
    setup.py
    rbtools/utils/aliases.py

Ship it!

rbtools/commands/alias.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Add period at end of help string.
```

Commit:

+	1b969165ca5d54e355b259cb840e7e0c4cb7fda8

Diff:

Revision 3 (+185 -49)

Show changes

	setup.py
	rbtools/clients/tests.py
	rbtools/commands/__init__.py
	rbtools/commands/alias.py
	rbtools/commands/main.py
	rbtools/utils/aliases.py
	rbtools/utils/filesystem.py
	rbtools/utils/testbase.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/testbase.py
    rbtools/commands/alias.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/tests.py
    rbtools/utils/filesystem.py
    setup.py
    rbtools/utils/aliases.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/testbase.py
    rbtools/commands/alias.py
    rbtools/commands/main.py
    rbtools/commands/__init__.py
    rbtools/clients/tests.py
    rbtools/utils/filesystem.py
    setup.py
    rbtools/utils/aliases.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (2964f1a)

rbtools/commands/alias.py (Diff revision 2)