Allow retrieving stderr output from subprocesses

Review Request #7204 — Created April 14, 2015 and submitted

Information

RBTools
release-0.7.x
4d52391...

Reviewers

The rbtools.utils.process.execute method now has a parameter that
allows retrieving the standard error output of a process.

Ran unit tests.

Manually tested the all combinations of the following parameters:

  • with_errors;
  • return_errors;
  • return_error_code;
  • split_lines;
  • ignore_errors; and
  • none_on_ignored_error.

The function returned the correct values in each case.

Description From Last Updated

Col: 1 W391 blank line at end of file

reviewbotreviewbot

Might say "standard error stream" to be consistent with the wording in with_errors.

gmyersgmyers
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/process.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/utils/process.py
    
    
  2. rbtools/utils/process.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W391 blank line at end of file
    
  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/utils/process.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/process.py
    
    
  2. 
      
gmyers
  1. 
      
  2. rbtools/utils/process.py (Diff revision 2)
     
     
     
    Show all issues

    Might say "standard error stream" to be consistent with the wording in with_errors.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/utils/process.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/process.py
    
    
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (d2e96f9)