Summary

Cleanup the rbtools.utils.process module

Review Request #7203 — Created April 14, 2015 and submitted April 15, 2015, 2:05 a.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Blocks

7204

Commit

c646e39...

Reviewers

Groups

rbtools

People

Description

The process module has long been in need of an overhaul. All parameters

and the return value of the process.execute function have been

documented. A bug where environment variables provided by the function

could be overridden by OS environment variables was fixed.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
"as UTF-8"	chipx86	April 15, 2015, 1:14 a.m.
"process's" Space after "returned as a"	chipx86	April 15, 2015, 1:40 a.m.
While here, can you remove the list in dict(...), to use a generator?	chipx86	April 15, 2015, 1:15 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/utils/process.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/process.py

Summary:

-	Cleanup the rbtools.process module
+	Cleanup the rbtools.utils.process module

rbtools/utils/process.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"as UTF-8"
```

rbtools/utils/process.py (Diff revision 1)

The issue has been resolved. Show all issues

"process's"

Space after "returned as a"

chipx86 April 15, 2015, 1:39 a.m.

There's still a missing space between "a" and the "six.text_type".

brennie April 15, 2015, 1:41 a.m.

Oops, that change wasn't committed when I posted.

rbtools/utils/process.py (Diff revision 1)

The issue has been resolved. Show all issues

While here, can you remove the list in dict(...), to use a generator?

Commit:

-	af873d488526e222d04dd5a98658a8f81772dba3
+	4ad4520600aab0d4609a7d969d80efa2b47bb4d1

Diff:

Revision 2 (+54 -13)

Show changes

rbtools/utils/process.py

Tool: Pyflakes
Processed Files:
    rbtools/utils/process.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/process.py

Commit:

-	4ad4520600aab0d4609a7d969d80efa2b47bb4d1
+	0877e7d1b1e8b1c8de718259cdb2f8718b6d200f

Diff:

Revision 3 (+55 -14)

Show changes

rbtools/utils/process.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/process.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/process.py

Commit:

-	0877e7d1b1e8b1c8de718259cdb2f8718b6d200f
+	c646e39db71103bf3bc1804b6d8b00e2efe0203f

Diff:

Revision 4 (+55 -14)

Show changes

rbtools/utils/process.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/process.py



Tool: Pyflakes
Processed Files:
    rbtools/utils/process.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (c9c2f78)