[WIP]ReviewBot ShellCheckTool

Review Request #7197 - Created April 12, 2015 and discarded

Jifei Wen
ReviewBot
release-0.2.x
reviewbot, students

ReviewBot ShellCheckTool

apt-get install cabal-install
cabal update
cabal install shellcheck
ln -s ~/.cabal/bin/shellcheck ~/usr/local/bin/shellcheck

  • 19
  • 0
  • 0
  • 0
  • 19
Description From Last Updated
We don't use module-level docstrings. Barret Rennie Barret Rennie
We organize our imports into three groups Python standard library imports Third party imports Project imports Given that, can we ... Barret Rennie Barret Rennie
"tool" not "model". Barret Rennie Barret Rennie
Single quotes around sh. Barret Rennie Barret Rennie
This sentence is implied by the first. Barret Rennie Barret Rennie
A few grammar mistakes here, how about: """Use ShellCheck to analyze the file and post the result.""" Barret Rennie Barret Rennie
Blank line between end of block and statement. Barret Rennie Barret Rennie
Blank line between statement and block. Barret Rennie Barret Rennie
Blank line between these. Barret Rennie Barret Rennie
Can we pull this out into a variable like shellcheck_cmd and then we can format the execute like: output = ... Barret Rennie Barret Rennie
You probably want none_on_ignored_error=True as well. Barret Rennie Barret Rennie
Blank line between statement and block. Barret Rennie Barret Rennie
What is cmm? This needs a better name. Barret Rennie Barret Rennie
Blank line between statement and block. Barret Rennie Barret Rennie
Can you include some sample output of shellcheck? Barret Rennie Barret Rennie
Blank line between statement and block. Also, can you make this regular expression a compiled constant on the class using ... Barret Rennie Barret Rennie
Can you also compile this? Please document what it does also. Barret Rennie Barret Rennie
Blank line between two blocks. If we are expecting a lot of strings to join, we should make cmm an ... Barret Rennie Barret Rennie
This should not be included in your change. Barret Rennie Barret Rennie
Review Bot
Barret Rennie
Jifei Wen
Review request changed

Status: Discarded

Change Summary:

Discarded in favour of https://reviews.reviewboard.org/r/7701.

Loading...