Allow rbt post to update review requests with submit-as option.
Review Request #7195 — Created April 11, 2015 and submitted
| Information | |
|---|---|
| halvorlu | |
| RBTools | |
| master | |
|
|
|
| 02734ba... | |
| Reviewers | |
| rbtools | |
Previously, rbt post with the submit-as option could only be used for creating review requests, not for updating them. The function guess_existing_review_request_id searched for review requests of the logged-in user, not the user specified by submit-as.
In order to allow updating of review requests that are not yet public, I've proposed a few changes in reviewboard (see #7196). This allows users with the can_submit_as_another_user permission to list nonpublic review requests.
- Publishing with
rbt post --submit-as=submitter, then updating the review request withrbt post -u --submit-as=submitterboth before and after it has been made public - Running unit tests
-
-
-
rbtools/utils/review_request.py (Diff revision 1) We're not very consistent in this statement, but we should have one keyword argument per line, really.
HA
Change Summary:
Added blank line and written keyword arguments on separate lines.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+18 -8) |
Tool: Pyflakes Processed Files: rbtools/commands/post.py rbtools/utils/review_request.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/utils/review_request.py